Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3-139 엔티티 다시 세팅하기 #5

Merged
merged 9 commits into from
Jun 26, 2024

Conversation

qjvk2880
Copy link
Contributor

작업 내용*

  • 최신화된 디비에 맞추어 엔티티를 재생성
  • Gender, Provider를 Enum으로 설정
  • sql 스크립트를 수정

고민한 내용*

  • validation을 아직 전부에 걸진 않았습니다.
  • 그룹 예약어로 인해 Community로 테이블 이름, 필드 이름 등을 변경하였습니다.

리뷰 요구사항

  • 필드 명 오타 없는지 정도만 봐주시면 될 것 같습니다!

@qjvk2880 qjvk2880 self-assigned this Jun 25, 2024
@@ -20,7 +16,8 @@

@Getter
@Entity
@Table(name = "pixel", indexes = @Index(name = "index__x__y", columnList = "x, y"))
@Table(name = "pixel")
// , indexes = @Index(name = "index__x__y", columnList = "x, y"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석은 지우는게 어떨까요??

package com.m3pro.groundflip.domain.entity;import java.util.Date;import com.m3pro.groundflip.domain.entity.global.BaseTimeEntity;import com.m3pro.groundflip.enums.Gender;import com.m3pro.groundflip.enums.Provider;import jakarta.persistence.Column;import jakarta.persistence.Entity;import jakarta.persistence.GeneratedValue;import jakarta.persistence.GenerationType;import jakarta.persistence.Id;import jakarta.persistence.Table;import jakarta.validation.constraints.Email;import jakarta.validation.constraints.Pattern;import lombok.AccessLevel;import lombok.AllArgsConstructor;import lombok.Builder;import lombok.Getter;import lombok.NoArgsConstructor;@Getter@Entity@Table(name = "user")@NoArgsConstructor(access = AccessLevel.PROTECTED)@AllArgsConstructor@Builderpublic class User extends BaseTimeEntity { @Id @GeneratedValue(strategy = GenerationType.IDENTITY) @Column(name = "user_id") private Long id; @Pattern(regexp = "[가-힣a-zA-Z0-9]{3,10}", message = "닉네임은 한글, 영어, 숫자를 조합해 3글자 이상, 10글자 이하입니다.") private String nickname; private Date birthYear; private Gender gender; private Provider provider; @Email private String email; private Date deletedAt;}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^M 고쳐야될것같아요~

@koomin1227 koomin1227 self-requested a review June 25, 2024 02:19
Copy link
Member

@koomin1227 koomin1227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERD 잘 고친 것 같네요~ 수고하셨습니다

Copy link
Contributor

@tkdals802 tkdals802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엔티티 테이블 변수명이 잘 만들어 진것 같습니다

@qjvk2880 qjvk2880 force-pushed the feature/M3-139-entityResetting branch from 3f4b994 to 879ba3d Compare June 26, 2024 01:01
Copy link

📝 테스트 커버리지 리포트

Overall Project 48.72% -2.2%
Files changed 91.43% 🍏

File Coverage
Provider.java 92.86% -7.14% 🍏
Gender.java 89.29% -10.71% 🍏

Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@qjvk2880 qjvk2880 merged commit 1658305 into develop Jun 26, 2024
3 checks passed
@koomin1227 koomin1227 deleted the feature/M3-139-entityResetting branch June 26, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants